feat: modal with settings profile #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Навзания папок и scss файлов с маленькой буквы |
NookieGrey
reviewed
Feb 16, 2025
| .avatar { | ||
| width: 150px; | ||
| height: 150px; | ||
| border-radius: 120px; |
NookieGrey
reviewed
Feb 16, 2025
| import {Button, Input} from "antd"; | ||
|
|
||
|
|
||
| export const AboutMySelf = () => { |
There was a problem hiding this comment.
Мы компоненты создаём как именованные функции, чтобы было проще дебажить
NookieGrey
reviewed
Feb 16, 2025
| src="https://s3-alpha-sig.figma.com/img/51fb/3b5b/0c423f431e973462f167a024bb6c3624?Expires=1740355200&Key-Pair-Id=APKAQ4GOSFWCW27IBOMQ&Signature=n13ooca0X0BnGvUK837M-1OjQ040scQ4DaFQL67NIhsiug1fHgvUxHbHvXgyBKi8jF2MX~EdWj602TGm2ZXOaYulnYV3VtJiXZF0binVakLJbEIlUzhTRc2QdcVobohvTXi5S-4BNBMYRlpMiaeYIgnJKplk5fNX0XfyZC~e61ivaYcLlUitFYOu1zjiPDkeym6vgqKSXAZr5akXSZBvET7J3byEQeRishMZidia9OP2tz-PoF3IXodwzd4wqnj7eZQrDL4L5jjKGTzBlRnjXoZcqnhNUFp6U6elyziPfB01Dhds5dGFNctW7rPIYzD2t5JKozaUXZ2U8NPbJ7T7ow__" | ||
| alt="avatar" className={styles.avatar}/> | ||
| <div> | ||
| <Button danger type="link">Удалить фото</Button> |
There was a problem hiding this comment.
Надо прикрутить i18n ко всем текстам
NookieGrey
reviewed
Feb 16, 2025
| </div> | ||
| </div> | ||
| <form className={styles.form}> | ||
| <div className={styles.formBlock}> |
There was a problem hiding this comment.
Как будто избыточний див и можно стили в форм загнать, нет?
NookieGrey
reviewed
Feb 16, 2025
| return ( | ||
| <div className={styles.settingsBlock}> | ||
| <div className={styles.settingsItem}> | ||
| <div className={styles.settingsItemBlockOfTitle}> |
There was a problem hiding this comment.
Вроде как избыточный класс, если сверстать дивами а не спан
NookieGrey
reviewed
Feb 16, 2025
src/pages/profile/Profile.tsx
Outdated
| body: styles.containerModal, | ||
| }} | ||
| title={ | ||
| <div style={{marginTop: "-6px", marginBottom: "20px"}}> |
NookieGrey
reviewed
Feb 16, 2025
src/pages/profile/Profile.tsx
Outdated
| </div> | ||
| } | ||
| > | ||
| {activeSection === 'О себе' ? ( |
There was a problem hiding this comment.
Так не надо, нужен независимый от текста уникальный код, на английском языке
NookieGrey
reviewed
Feb 16, 2025
| @@ -0,0 +1,13 @@ | |||
| .modal { | |||
| min-height: 603px; | |||
There was a problem hiding this comment.
в чём прикол мин, макс?
NookieGrey
reviewed
Feb 16, 2025
| </div> | ||
| <div> | ||
| <span className={styles.titleOfInput}>Расскажите о себе</span> | ||
| <Input.TextArea rows={4} autoSize={{minRows: 5, maxRows: 5}}/> |
There was a problem hiding this comment.
Здесь тоже не ясно, а почему сразу rows={5} не установить? и autoSize=false?
There was a problem hiding this comment.
так я пробовал, autosize не работает
NookieGrey
reviewed
Feb 16, 2025
| <> | ||
| <div className={styles.blockAvatar}> | ||
| <img | ||
| src="https://s3-alpha-sig.figma.com/img/51fb/3b5b/0c423f431e973462f167a024bb6c3624?Expires=1740355200&Key-Pair-Id=APKAQ4GOSFWCW27IBOMQ&Signature=n13ooca0X0BnGvUK837M-1OjQ040scQ4DaFQL67NIhsiug1fHgvUxHbHvXgyBKi8jF2MX~EdWj602TGm2ZXOaYulnYV3VtJiXZF0binVakLJbEIlUzhTRc2QdcVobohvTXi5S-4BNBMYRlpMiaeYIgnJKplk5fNX0XfyZC~e61ivaYcLlUitFYOu1zjiPDkeym6vgqKSXAZr5akXSZBvET7J3byEQeRishMZidia9OP2tz-PoF3IXodwzd4wqnj7eZQrDL4L5jjKGTzBlRnjXoZcqnhNUFp6U6elyziPfB01Dhds5dGFNctW7rPIYzD2t5JKozaUXZ2U8NPbJ7T7ow__" |
There was a problem hiding this comment.
Используй картинку из info и вынеси её на уровень выше
NookieGrey
reviewed
Feb 16, 2025
| <span className={styles.titleOfInput}>Имя и имя пользователя</span> | ||
| <div className={styles.blockOfNameAndLoginInput}> | ||
| <Input type="text" placeholder="Имя"/> | ||
| <Input type="text" placeholder="@Юзернейм"/> |
NookieGrey
reviewed
Feb 16, 2025
| padding: 20px; | ||
| } | ||
|
|
||
| .headerModal { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.